Only log basic response information #3508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Feb 6, 2020
JDutil
force-pushed
the
jdutil/gateway-loggingg
branch
2 times, most recently
from
85a3823 to
9fdf9fd
Compare
houndci-bot
reviewed
Feb 7, 2020
JDutil
force-pushed
the
jdutil/gateway-loggingg
branch
from
9fdf9fd to
b97da39
Compare
When logging a gateway error response there is a params field, which provides extra information about the request. That information can include useful information like the payment amount, but it can also include PII such as a full billing address. By logging the full error response in yaml that PII can end up in your logs, which is not desirable and potentially against the law. Therefore we should only log the minimal information needed from the response.
JDutil
force-pushed
the
jdutil/gateway-loggingg
branch
from
b97da39 to
63169fe
Compare
There was a problem hiding this comment.
@JDutil thanks for this improvement! I left a question regarding the specs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When logging a gateway error response there is a params field,
which provides extra information about the request. That information
can include useful information like the payment amount, but it can
also include PII such as a full billing address.
By logging the full error response in yaml that PII can end up in your
logs, which is not desirable and potentially against the law. Therefore
we should only log the minimal information needed from the response.
Checklist: